Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix y axis auto scaling #1112

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix y axis auto scaling #1112

merged 2 commits into from
Feb 15, 2024

Conversation

AaronPlave
Copy link
Contributor

Fixes y-axis autoscaling for the "Autofit Time Window" Domain Fitting option. Closes #1043.

Testing:

  • Load a plan with a variety of line plots
  • Enable "Autofit Time Window" domain fitting option in the timeline editor for the line plots if not already enabled
  • Pan and zoom around the data and ensure that the domain fitting correctly reflects the available data. Mainly, ensure that neighboring points (right outside of the view time range) are taken into account when computing the domain.

@AaronPlave AaronPlave requested a review from a team as a code owner February 1, 2024 20:56
@AaronPlave AaronPlave self-assigned this Feb 1, 2024
@AaronPlave AaronPlave force-pushed the fix/1043/auto-scale-fix branch from 47edf26 to 8471ac8 Compare February 1, 2024 21:33
duranb
duranb approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AaronPlave AaronPlave force-pushed the fix/1043/auto-scale-fix branch from 8471ac8 to 5ec82bc Compare February 15, 2024 15:31
@AaronPlave AaronPlave merged commit 0d5dc69 into develop Feb 15, 2024
4 checks passed
@AaronPlave AaronPlave deleted the fix/1043/auto-scale-fix branch February 15, 2024 15:39
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@AaronPlave
Fix y axis auto scaling (#1112)
a55fd14 
* Fix y axis auto scaling
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@AaronPlave @JosephVolosin
Fix y axis auto scaling (#1112)
d982f22 
* Fix y axis auto scaling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@AaronPlave AaronPlave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto fit scale domain not taking connecting points into account
2 participants
@AaronPlave @duranb